Fix handling of OD policy with no child

murgatroid99 · murgatroid99 · commit ed70a0b38114 · 2023-06-27T10:11:45.000-07:00
diff --git a/packages/grpc-js/src/load-balancer-outlier-detection.ts b/packages/grpc-js/src/load-balancer-outlier-detection.ts
@@ -113,7 +113,7 @@ export class OutlierDetectionLoadBalancingConfig implements LoadBalancingConfig
     failurePercentageEjection: Partial<FailurePercentageEjectionConfig> | null,
     private readonly childPolicy: LoadBalancingConfig[]
   ) {
-    if (childPolicy[0].getLoadBalancerName() === 'pick_first') {
+    if (childPolicy.length > 0 && childPolicy[0].getLoadBalancerName() === 'pick_first') {
       throw new Error('outlier_detection LB policy cannot have a pick_first child policy');
     }
     this.intervalMs = intervalMs ?? 10_000;

Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,7 @@ export class OutlierDetectionLoadBalancingConfig implements LoadBalancingConfig`
`113`	`113`	`failurePercentageEjection: Partial<FailurePercentageEjectionConfig> \| null,`
`114`	`114`	`private readonly childPolicy: LoadBalancingConfig[]`
`115`	`115`	`) {`
`116`		`- if (childPolicy[0].getLoadBalancerName() === 'pick_first') {`
	`116`	`+ if (childPolicy.length > 0 && childPolicy[0].getLoadBalancerName() === 'pick_first') {`
`117`	`117`	`throw new Error('outlier_detection LB policy cannot have a pick_first child policy');`
`118`	`118`	`}`
`119`	`119`	`this.intervalMs = intervalMs ?? 10_000;`