Switch to bazelmod #618
Open
Switch to bazelmod #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ratnikov I was just lurking on the issue that this patch is targeted towards. Is there an alternative/competing patch thats not listed on the issue? Nice work regardless, it would be good to see bzlmod support. Hopefully you're able to get the CLA and stuff and find a reviewer 😄 🤞 |
|
I'm not aware of any alternative work. I've been using my patch internally for a bit, so so far it works. :) We've been making some progress on our end to get the EasyCLA hurdle out of the way, so I'm hopping that that will be green in a week or two. I have a feeling that may elicit some input from maintainers on its mergability. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #398
I'm open to which version to pick, just happy I can depend on grpc-kotlin using bazel mod. :)