Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ManagedChannelBuilder doesn't have maxMessageSize #2307

Closed
ejona86 opened this issue Sep 28, 2016 · 2 comments
Closed

ManagedChannelBuilder doesn't have maxMessageSize #2307

ejona86 opened this issue Sep 28, 2016 · 2 comments
Milestone

Comments

@ejona86
Copy link
Member

ejona86 commented Sep 28, 2016

This makes it more annoying to override the maxMessageSize, because you have to know which implementation you are using.

Note that if you specify the actual implementation, this is easy, but the problem is needing to specify the implementation.

Instead of:

ManagedChannelBuilder.forTarget(...)
   .maxMessageSize(SIZE)
   .build();

You are forced to do:

NettyChannelBuilder.forTarget(...)
   .maxMessageSize(SIZE)
   .build();
@ejona86 ejona86 added this to the Next milestone Sep 28, 2016
@ejona86
Copy link
Member Author

ejona86 commented Sep 28, 2016

This is slightly tricky since things like InProcess transport doesn't support maxMessageSize (infinite is always allowed). We can add support to InProcess transport, although that comes at a performance cost since today the messages aren't generally serialized. The other option is for it to just ignore the setting.

@ejona86
Copy link
Member Author

ejona86 commented Nov 7, 2016

Fixed by #2382

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant