Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --incompatible_enable_proto_toolchain_resolution #11152

Open
kusaeva opened this issue May 6, 2024 · 2 comments
Open

Support --incompatible_enable_proto_toolchain_resolution #11152

kusaeva opened this issue May 6, 2024 · 2 comments
Labels
enhancement help wanted Waiting on reporter there was a request for more information without a response or answer or advice has been provided
Milestone

Comments

@kusaeva
Copy link

kusaeva commented May 6, 2024

Is your feature request related to a problem?

The problem is need to compile protoc instead of using prebuilt binary while building java_grpc_library

Describe the solution you'd like

Support --incompatible_enable_proto_toolchain_resolution bazel flag so users can override protoc compiled from sources with prebuilt binary, as already done in rules_python or WIP in rules_go

Describe alternatives you've considered

Additional context

Examples of declarations toolchains for other languages that already support the feature here

@kannanjgithub
Copy link
Contributor

Feel free to raise a PR for this.

@ejona86 ejona86 added this to the Next milestone May 9, 2024
@sergiitk sergiitk added the Waiting on reporter there was a request for more information without a response or answer or advice has been provided label May 9, 2024
@mortenmj
Copy link

mortenmj commented Jan 4, 2025

@kannanjgithub I had a look at what it would take to make a PR for this, and there are two parts.

One is using a toolchain to provide protoc, to avoid the dependency on @com_google_protobuf//:protoc_lib. That is pretty straight forward. I could make a separate PR for that, as it would be pretty small and easy to review.

The second part involves the dependency on @com_google_protobuf//:protoc_lib, which I don't think is very easy to avoid. If we make it easy for the user to declare their own java_rpc_toolchain, users could opt to consume prebuilt binaries from maven while still maintaining the existing default of building from source. Does that sound like something to move ahead with?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help wanted Waiting on reporter there was a request for more information without a response or answer or advice has been provided
Projects
None yet
Development

No branches or pull requests

5 participants