Skip to content

Commit d6830d7

Browse files
authored
Change many api deps to implementation deps
These look pretty fair now, mostly only exposing grpc-api and annotations as api dependencies.
1 parent 8c4f4e0 commit d6830d7

File tree

23 files changed

+41
-14
lines changed

23 files changed

+41
-14
lines changed

alts/build.gradle

+3-1
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,9 @@ plugins {
1010
description = "gRPC: ALTS"
1111

1212
dependencies {
13-
api project(':grpc-core')
13+
api project(':grpc-api')
1414
implementation project(':grpc-auth'),
15+
project(':grpc-core'),
1516
project(':grpc-grpclb'),
1617
project(':grpc-protobuf'),
1718
project(':grpc-stub'),
@@ -27,6 +28,7 @@ dependencies {
2728

2829
testImplementation project(':grpc-testing'),
2930
testFixtures(project(':grpc-core')),
31+
project(':grpc-inprocess'),
3032
project(':grpc-testing-proto'),
3133
libraries.guava,
3234
libraries.junit,

android-interop-testing/build.gradle

+1
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@ dependencies {
6868
implementation 'com.google.android.gms:play-services-base:18.0.1'
6969

7070
implementation project(':grpc-android'),
71+
project(':grpc-core'),
7172
project(':grpc-auth'),
7273
project(':grpc-census'),
7374
project(':grpc-okhttp'),

android/build.gradle

+2-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,8 @@ repositories {
3535
}
3636

3737
dependencies {
38-
api project(':grpc-core')
38+
api project(':grpc-api')
39+
implementation project(':grpc-core')
3940
implementation libraries.guava
4041
testImplementation project('::grpc-okhttp')
4142
testImplementation libraries.androidx.test.core

api/build.gradle

+1
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ dependencies {
4444
testFixturesImplementation libraries.guava,
4545
libraries.junit,
4646
libraries.mockito.core
47+
testImplementation project(':grpc-core')
4748
testImplementation project(':grpc-testing')
4849
testImplementation libraries.guava.testlib
4950

auth/build.gradle

+1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ dependencies {
1919
libraries.google.auth.credentials
2020
implementation libraries.guava
2121
testImplementation project(':grpc-testing'),
22+
project(':grpc-core'),
2223
libraries.google.auth.oauth2Http
2324
signature libraries.signature.java
2425
signature libraries.signature.android

benchmarks/build.gradle

+1
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ tasks.named("jar").configure {
2626

2727
dependencies {
2828
implementation project(':grpc-core'),
29+
project(':grpc-inprocess'),
2930
project(':grpc-netty'),
3031
project(':grpc-okhttp'),
3132
project(':grpc-stub'),

binder/build.gradle

+3-1
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,9 @@ repositories {
3535
}
3636

3737
dependencies {
38-
api project(':grpc-core')
38+
api project(':grpc-api')
3939

40+
implementation project(':grpc-core')
4041
implementation libraries.androidx.annotation
4142
implementation libraries.androidx.core
4243
implementation libraries.androidx.lifecycle.common
@@ -51,6 +52,7 @@ dependencies {
5152
testImplementation libraries.guava.testlib
5253
testImplementation libraries.truth
5354
testImplementation project(':grpc-testing')
55+
testImplementation project(':grpc-inprocess')
5456
testImplementation testFixtures(project(':grpc-core'))
5557

5658
androidTestAnnotationProcessor libraries.auto.value

core/build.gradle

+1
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ dependencies {
3333
libraries.truth,
3434
project(':grpc-testing')
3535
testImplementation testFixtures(project(':grpc-api')),
36+
project(':grpc-inprocess'),
3637
project(':grpc-testing')
3738
testImplementation libraries.guava.testlib
3839

cronet/build.gradle

+2-1
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,9 @@ android {
4343
}
4444

4545
dependencies {
46-
api project(':grpc-core'),
46+
api project(':grpc-api'),
4747
libraries.cronet.api
48+
implementation project(':grpc-core')
4849
implementation libraries.guava
4950
testImplementation project(':grpc-testing')
5051

examples/build.gradle

+1
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ dependencies {
3939
runtimeOnly "io.grpc:grpc-netty-shaded:${grpcVersion}"
4040

4141
testImplementation "io.grpc:grpc-testing:${grpcVersion}"
42+
testImplementation "io.grpc:grpc-inprocess:${grpcVersion}"
4243
testImplementation "junit:junit:4.13.2"
4344
testImplementation "org.mockito:mockito-core:4.4.0"
4445
}

examples/example-hostname/build.gradle

+1
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ dependencies {
3535

3636
testImplementation 'junit:junit:4.13.2'
3737
testImplementation "io.grpc:grpc-testing:${grpcVersion}"
38+
testImplementation "io.grpc:grpc-inprocess:${grpcVersion}"
3839
}
3940

4041
protobuf {

examples/example-jwt-auth/build.gradle

+1
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ dependencies {
3838
runtimeOnly "io.grpc:grpc-netty-shaded:${grpcVersion}"
3939

4040
testImplementation "io.grpc:grpc-testing:${grpcVersion}"
41+
testImplementation "io.grpc:grpc-inprocess:${grpcVersion}"
4142
testImplementation "junit:junit:4.13.2"
4243
testImplementation "org.mockito:mockito-core:4.4.0"
4344
}

examples/example-oauth/build.gradle

+1
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ dependencies {
3838
runtimeOnly "io.grpc:grpc-netty-shaded:${grpcVersion}"
3939

4040
testImplementation "io.grpc:grpc-testing:${grpcVersion}"
41+
testImplementation "io.grpc:grpc-inprocess:${grpcVersion}"
4142
testImplementation "junit:junit:4.13.2"
4243
testImplementation "org.mockito:mockito-core:4.4.0"
4344
}

inprocess/build.gradle

+2-1
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,9 @@ tasks.named("jar").configure {
1414
}
1515

1616
dependencies {
17-
api project(':grpc-core')
17+
api project(':grpc-api')
1818

19+
implementation project(':grpc-core')
1920
implementation libraries.guava
2021
testImplementation project(':grpc-testing'),
2122
testFixtures(project(':grpc-core'))

interop-testing/build.gradle

+3
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ dependencies {
2424
project(':grpc-rls'),
2525
project(':grpc-services'),
2626
project(':grpc-testing'),
27+
project(':grpc-protobuf-lite'),
2728
project(path: ':grpc-xds', configuration: 'shadow'),
2829
libraries.hdrhistogram,
2930
libraries.truth,
@@ -49,6 +50,8 @@ dependencies {
4950
project(':grpc-rls')
5051
testImplementation testFixtures(project(':grpc-api')),
5152
testFixtures(project(':grpc-core')),
53+
project(':grpc-inprocess'),
54+
project(':grpc-core'),
5255
libraries.mockito.core,
5356
libraries.okhttp
5457
alpnagent libraries.jetty.alpn.agent

netty/build.gradle

+3-2
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,10 @@ tasks.named("jar").configure {
2020
}
2121

2222
dependencies {
23-
api project(':grpc-core'),
23+
api project(':grpc-api'),
2424
libraries.netty.codec.http2
25-
implementation libs.netty.handler.proxy,
25+
implementation project(':grpc-core'),
26+
libs.netty.handler.proxy,
2627
libraries.guava,
2728
libraries.errorprone.annotations,
2829
libraries.perfmark.api,

okhttp/build.gradle

+2-1
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,9 @@ tasks.named("jar").configure {
1515
}
1616

1717
dependencies {
18-
api project(':grpc-core')
18+
api project(':grpc-api')
1919
implementation project(':grpc-util'),
20+
project(':grpc-core'),
2021
libraries.okio,
2122
libraries.guava,
2223
libraries.perfmark.api

protobuf/build.gradle

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ dependencies {
2727
exclude group: 'com.google.api', module: 'api-common'
2828
}
2929

30-
api (project(':grpc-protobuf-lite')) {
30+
implementation (project(':grpc-protobuf-lite')) {
3131
exclude group: 'com.google.protobuf', module: 'protobuf-javalite'
3232
}
3333

rls/build.gradle

+1
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ dependencies {
2525
compileOnly libraries.javax.annotation
2626
testImplementation libraries.truth,
2727
project(':grpc-grpclb'),
28+
project(':grpc-inprocess'),
2829
project(':grpc-testing'),
2930
project(':grpc-testing-proto'),
3031
testFixtures(project(':grpc-core'))

services/build.gradle

+4-3
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,10 @@ tasks.named("jar").configure {
2323
}
2424

2525
dependencies {
26-
api project(':grpc-protobuf'),
27-
project(':grpc-stub'),
28-
project(':grpc-util')
26+
api project(':grpc-stub')
2927
implementation project(':grpc-core'),
28+
project(':grpc-protobuf'),
29+
project(':grpc-util'),
3030
libraries.protobuf.java.util,
3131
libraries.guava.jre // JRE required by protobuf-java-util
3232

@@ -35,6 +35,7 @@ dependencies {
3535
libraries.gson // to fix checkUpperBoundDeps error here
3636
compileOnly libraries.javax.annotation
3737
testImplementation project(':grpc-testing'),
38+
project(':grpc-inprocess'),
3839
libraries.netty.transport.epoll, // for DomainSocketAddress
3940
testFixtures(project(':grpc-core')),
4041
testFixtures(project(':grpc-api'))

stub/build.gradle

+1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ dependencies {
1919
libraries.guava
2020
implementation libraries.errorprone.annotations
2121
testImplementation libraries.truth,
22+
project(':grpc-inprocess'),
2223
project(':grpc-testing'),
2324
testFixtures(project(':grpc-api'))
2425
signature libraries.signature.java

testing/build.gradle

+3-2
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,11 @@ plugins {
99
description = "gRPC: Testing"
1010

1111
dependencies {
12-
api project(':grpc-inprocess'),
13-
project(':grpc-util'),
12+
api project(':grpc-util'),
1413
project(':grpc-stub'),
1514
libraries.junit
15+
implementation project(':grpc-inprocess')
16+
implementation project(':grpc-core')
1617
// Only io.grpc.internal.testing.StatsTestUtils depends on opencensus_api, for internal use.
1718
compileOnly libraries.opencensus.api
1819
runtimeOnly project(":grpc-api") // Pull in newer version than census-api

xds/build.gradle

+2
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ dependencies {
4848
compileOnly sourceSets.thirdparty.output
4949
implementation project(':grpc-stub'),
5050
project(':grpc-core'),
51+
project(':grpc-util'),
5152
project(':grpc-services'),
5253
project(':grpc-auth'),
5354
project(path: ':grpc-alts', configuration: 'shadow'),
@@ -58,6 +59,7 @@ dependencies {
5859
def nettyDependency = implementation project(':grpc-netty')
5960

6061
testImplementation project(':grpc-rls')
62+
testImplementation project(':grpc-inprocess')
6163
testImplementation testFixtures(project(':grpc-core')),
6264
testFixtures(project(':grpc-api')),
6365
testFixtures(project(':grpc-util'))

0 commit comments

Comments
 (0)