From 0804b55f72375ef6c2887ce497b14b4dcdb437dc Mon Sep 17 00:00:00 2001 From: Sergii Tkachenko Date: Fri, 7 Feb 2025 12:20:17 -0800 Subject: [PATCH] notes on addressing FilterChainMatch issue --- xds/src/main/java/io/grpc/xds/XdsServerWrapper.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/xds/src/main/java/io/grpc/xds/XdsServerWrapper.java b/xds/src/main/java/io/grpc/xds/XdsServerWrapper.java index a934dfde2f0..56f673fba62 100644 --- a/xds/src/main/java/io/grpc/xds/XdsServerWrapper.java +++ b/xds/src/main/java/io/grpc/xds/XdsServerWrapper.java @@ -116,8 +116,12 @@ public void uncaughtException(Thread t, Throwable e) { private volatile Server delegate; // Must be updated in the sync context. - // TODO(sergiitk): [QUESTION] should this be per filter chain too? + // TODO(sergiitk): [QUESTION] consider the implication of filterchain equality, during updates. + // how to identify this is the same filter chain + // - based on index? + // - based on FilterChainMatch? private final HashMap activeFilters = new HashMap<>(); + // private final HashMap> activeFilters = new HashMap<>(); XdsServerWrapper( String listenerAddress,