Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpclog: refactor existing logger interfaces for better interoparability #7431

Closed
wants to merge 1 commit into from

Conversation

clement2026
Copy link
Contributor

Fixes: #6044

What's changed:

  • Implement fun V(l int) bool for PrefixLogger, and delegate calls to its logger field.

@easwars Just let me know if I misunderstood anything or if there’s more to do.

RELEASE NOTES: none

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.58%. Comparing base (2bcbcab) to head (b82b049).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7431      +/-   ##
==========================================
+ Coverage   81.52%   81.58%   +0.05%     
==========================================
  Files         350      350              
  Lines       26879    26886       +7     
==========================================
+ Hits        21913    21934      +21     
+ Misses       3772     3765       -7     
+ Partials     1194     1187       -7     
Files Coverage Δ
internal/grpclog/prefixLogger.go 95.83% <100.00%> (+0.37%) ⬆️
internal/grpclog/grpclog.go 73.07% <60.00%> (-3.12%) ⬇️

... and 22 files with indirect coverage changes

@aranjans aranjans added this to the 1.66 Release milestone Jul 23, 2024
@easwars easwars removed the P2 label Jul 23, 2024
@easwars
Copy link
Contributor

easwars commented Aug 6, 2024

Upon reviewing your PR, I realized that we need a bunch of other changes as part of this refactor. So, I ended up sending #7465.

I'm closing this since the PR mentioned above performs a more broader refactor of the grpclog package.

Thanks for your contributions. And feel free to look at our "Help Wanted" issues if you are interested in making other contributions to our repo.

@easwars easwars closed this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grpclog: refactor existing logger interfaces for better interoparability
3 participants