Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xds/bootstrap: add testing support to generate config #7326

Merged
merged 5 commits into from
Jun 21, 2024
Merged

xds/bootstrap: add testing support to generate config #7326

merged 5 commits into from
Jun 21, 2024

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Jun 15, 2024 •
edited
Loading

Following up from #7299, this PR adds testing support to generate bootstrap configuration.

#a71-xds-fallback

RELEASE NOTES: none

@easwars easwars added this to the 1.66 Release milestone Jun 15, 2024
@easwars easwars force-pushed the xds_bootstrap_testing_cleanup branch from a0d455b to 6c9e214 Compare June 17, 2024 14:45
@easwars easwars requested a review from arvindbr8 June 17, 2024 17:40
@arvindbr8 arvindbr8 assigned easwars and unassigned arvindbr8 Jun 17, 2024
@easwars easwars assigned arvindbr8 and unassigned easwars Jun 18, 2024
@easwars
Copy link
Contributor Author

easwars commented Jun 18, 2024

@arvindbr8 : Unfortunately this has morphed into a nasty monster. Didn't realize the xDS management server was used by so many of our tests. Happy reviewing :p

arvindbr8
arvindbr8 requested changes Jun 19, 2024
View reviewed changes
Copy link
Member

@arvindbr8 arvindbr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly minor comments. Please let me know what you think

internal/testutils/xds/e2e/bootstrap.go Outdated Show resolved Hide resolved
internal/testutils/xds/e2e/bootstrap.go Outdated Show resolved Hide resolved
internal/testutils/xds/e2e/bootstrap.go Outdated Show resolved Hide resolved
internal/testutils/xds/e2e/bootstrap.go Outdated Show resolved Hide resolved
internal/testutils/xds/e2e/server.go Show resolved Hide resolved
test/xds/xds_server_integration_test.go Outdated Show resolved Hide resolved
xds/internal/httpfilter/fault/fault_test.go Outdated Show resolved Hide resolved
xds/internal/test/e2e/controlplane.go Outdated Show resolved Hide resolved
xds/internal/xdsclient/tests/cds_watchers_test.go Outdated Show resolved Hide resolved
xds/internal/xdsclient/tests/cds_watchers_test.go Outdated Show resolved Hide resolved
@arvindbr8 arvindbr8 assigned easwars and unassigned arvindbr8 Jun 19, 2024
@arvindbr8
Copy link
Member

Sorry for making you open the can of worms here 😢

@easwars easwars assigned arvindbr8 and unassigned easwars Jun 20, 2024
arvindbr8
arvindbr8 approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@arvindbr8 arvindbr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

internal/testutils/xds/e2e/server.go Show resolved Hide resolved
internal/testutils/xds/e2e/bootstrap.go Outdated Show resolved Hide resolved
internal/testutils/xds/e2e/server.go Show resolved Hide resolved
@arvindbr8 arvindbr8 assigned easwars and unassigned arvindbr8 Jun 20, 2024
@easwars
Copy link
Contributor Author

easwars commented Jun 21, 2024

LGTM 👍

Thank you very much for the review.

@easwars easwars merged commit f1b7f41 into grpc:master Jun 21, 2024
11 checks passed
@easwars easwars deleted the xds_bootstrap_testing_cleanup branch June 21, 2024 14:01
@tbg tbg mentioned this pull request Nov 27, 2024
Draft
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvindbr8 arvindbr8 arvindbr8 approved these changes

Assignees

@easwars easwars

Labels
Type: Testing
Projects
None yet
Milestone
1.66 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@easwars @arvindbr8