[advancedTLS] Removed deprecated APIs in advancedTLS #7303
Conversation
gtcooke94
added
Type: API Change
security/advancedtls/crl.go
Outdated
| @@ -319,7 +183,7 @@ func fetchCRL(c *x509.Certificate, crlVerifyCrt []*x509.Certificate, cfg Revocat | |||
| } | |||
| return crl, nil | |||
| } | |||
| return fetchIssuerCRL(c.RawIssuer, crlVerifyCrt, cfg) | |||
| return nil, fmt.Errorf("trying to fetch CRL but CRLProvider is nil") | |||
There was a problem hiding this comment.
Should we move this check to become the fist thing in this function?
There was a problem hiding this comment.
Good call, changed
|
Note: the rel notes in the PR description is only for grpc-Go releases. We would need to come up with rel notes for the advancedTLS release. Also since the fields were deprecated before the 1.0 release, i would rather not mention anything in the rel notes for 1.0 |
|
That's a good point - I removed release notes |
There was a problem hiding this comment.
LGTM.
As for 1.0 release, I think we should just audit everything once again. For eg: I see we have a separate module under security/advancedtls/examples/ which has a replace directive to the advancedTLS module. So after release, we should also update the go.mod to reference to the right release
This PR removes the following deprecated APIs in preparation for a 1.0 release of advancedTLS:
The first list were simply renamed
The second list are fully deprecated features in the CRL stack - use CRL providers instead. For reading a directory, the
FileWatcherCRLProvidershould be a relatively simple replacement.RELEASE NOTES: None