Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile: perfect PHONY #7076

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Makefile: perfect PHONY #7076

merged 1 commit into from
Apr 9, 2024

Conversation

imalasong
Copy link
Contributor

@imalasong imalasong commented Apr 3, 2024 •
edited by arvindbr8
Loading

add deps、testsubmodule、testdeps to PHONY

RELEASE NOTES: none

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Apr 3, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: imalasong / name: imalasong (5107145)

arvindbr8
arvindbr8 approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@arvindbr8 arvindbr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. looks good to me.

CC'ing @dfawley for a second review per repo policy

@arvindbr8 arvindbr8 requested a review from dfawley April 5, 2024 23:44
@arvindbr8 arvindbr8 added the Type: Internal Cleanup Refactors, etc label Apr 5, 2024
@arvindbr8 arvindbr8 added this to the 1.64 Release milestone Apr 5, 2024
@dfawley dfawley merged commit 554f107 into grpc:master Apr 9, 2024
13 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley approved these changes

@arvindbr8 arvindbr8 arvindbr8 approved these changes

Assignees

@dfawley dfawley

Labels
Type: Internal Cleanup Refactors, etc
Projects
None yet
Milestone
1.64 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@imalasong @arvindbr8 @dfawley