Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc: Export header list sizes in DialOption and ServerOption #7033

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

ZhouyihaiDing
Copy link
Contributor

@ZhouyihaiDing ZhouyihaiDing commented Mar 11, 2024

Similar to #1902, it is good to export the header list sizes for users to know what is the existing metadata size limit.

RELEASE NOTES: none

@ZhouyihaiDing ZhouyihaiDing force-pushed the metadata_size_option branch 2 times, most recently from 777eb9b to 0650caf Compare March 11, 2024 22:24
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Merging #7033 (aa603cd) into master (7c37770) will increase coverage by 0.14%.
Report is 15 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7033      +/-   ##
==========================================
+ Coverage   82.38%   82.52%   +0.14%     
==========================================
  Files         296      300       +4     
  Lines       31475    31355     -120     
==========================================
- Hits        25931    25877      -54     
+ Misses       4486     4425      -61     
+ Partials     1058     1053       -5     
Files Coverage Δ
dialoptions.go 89.16% <100.00%> (+0.09%) ⬆️
server.go 81.38% <100.00%> (+0.15%) ⬆️

... and 43 files with indirect coverage changes

server.go Outdated Show resolved Hide resolved
@dfawley dfawley added the Type: Feature New features or improvements in behavior label Apr 1, 2024
@dfawley dfawley added this to the 1.64 Release milestone Apr 1, 2024
@dfawley dfawley changed the title Export header list sizes in DialOption and ServerOption grpc: Export header list sizes in DialOption and ServerOption Apr 1, 2024
@dfawley dfawley merged commit 17d1039 into grpc:master Apr 1, 2024
14 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Feature New features or improvements in behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants