Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xds: move virtual host matcher test to the xdsresource package #6680

Merged
merged 1 commit into from
Oct 4, 2023
Merged

xds: move virtual host matcher test to the xdsresource package #6680

merged 1 commit into from
Oct 4, 2023

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Oct 3, 2023

RELEASE NOTES: none

@easwars easwars requested a review from zasweq October 3, 2023 22:13
@easwars easwars added this to the 1.59 Release milestone Oct 3, 2023
zasweq
zasweq approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@zasweq zasweq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zasweq zasweq assigned easwars and unassigned zasweq Oct 4, 2023
@easwars easwars merged commit 93dbc05 into grpc:master Oct 4, 2023
10 checks passed
@easwars easwars deleted the xds_resolver_cleanup_1 branch October 4, 2023 16:10
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zasweq zasweq zasweq approved these changes

Assignees

@easwars easwars

Labels
Type: Testing
Projects
None yet
Milestone
1.59 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@easwars @zasweq