xds/googledirectpath: fix google-c2p resolver test case involving bootstrap env config #6657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easwars
approved these changes
Sep 22, 2023
| defer func() { onGCE = oldOnGCE }() | ||
|
|
||
| // don't actually read the bootstrap file contents | ||
| tXDSClient := &testXDSClient{closed: make(chan struct{}, 1)} |
There was a problem hiding this comment.
Nit: tXDSClient is a bit hard on the eyes. Can we simply name this xdsClient?
|
@easwars please merge if this looks good (I don't have access) |
easwars
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6572
It looks like this test was originally written assuming that federation was default off.
When federation was defaulted on, the expectations changed. Update to fix expectations and make the test behave the ~same whether it's ran on GCE or not.
cc @easwars
RELEASE NOTES: none