resolver: remove outdated Target examples #6547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
easwars
approved these changes
Aug 14, 2023
|
@philippgille : Would you mind rebasing your branch to master. We recently fixed something that will take care of one of the failing tests in this PR. Thanks. |
|
@ginayeh : For second set of eyes |
dfawley
approved these changes
Aug 14, 2023
|
The failing test is vet-proto which does not need to pass in order to be merged (and appears to be broken again by a recent upstream change). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to resolve #6496, in which an outdated Godoc was noticed. In the past the
resolver.Targetstruct contained three different fields, but nowadays it's onlyURL, but the examples in the Godoc still referenced the old fields.As the
Targetdoesn't seem to be usually created directly by a user of grpc-go, but instead throughDialorDialContext, it seems reasonable to just remove the examples instead of replacing them with an example where a target string is manually parsed withurl.Parse.RELEASE NOTES: none