Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple: update dependencies after 1.57 branch cut #6452

Merged
merged 3 commits into from
Jul 18, 2023

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Jul 14, 2023

Ran the following commands:

for x in $(find . -name 'go.mod'); do
  pushd "$(dirname $x)"
  go get -u ./...
  go mod tidy -compat=1.17
  popd
done

RELEASE NOTES: none

@easwars easwars requested a review from dfawley July 14, 2023 20:46
@easwars easwars added the Type: Meta Github repo, process, etc label Jul 14, 2023
@easwars easwars added this to the 1.58 Release milestone Jul 14, 2023
@easwars
Copy link
Contributor Author

easwars commented Jul 14, 2023

The vet-proto failures seem to be on expected lines since this PR updates the protoc-gen-go version to v1.31.0.

@dfawley
Copy link
Member

dfawley commented Jul 14, 2023

The vet-proto failures seem to be on expected lines since this PR updates the protoc-gen-go version to v1.31.0.

Can you update the pb.gos in this PR too, then, please?

@easwars
Copy link
Contributor Author

easwars commented Jul 14, 2023

The vet-proto failures seem to be on expected lines since this PR updates the protoc-gen-go version to v1.31.0.

Can you update the pb.gos in this PR too, then, please?

Done.

But now I see a different error which does seem related to protoc-gen-go.

# github.com/golang/glog
Error: ../../../go/pkg/mod/github.com/golang/[email protected]/glog_file_other.go:27:6: abortProcess redeclared in this block
Error: 	../../../go/pkg/mod/github.com/golang/[email protected]/glog_file_linux.go:33:6: other declaration of abortProcess
note: module requires Go 1.19

It is interesting that the go get -u command updated glog to a version that requires Go 1.19 while our go.mod says Go version is 1.17.

@dfawley
Copy link
Member

dfawley commented Jul 17, 2023

It is interesting that the go get -u command updated glog to a version that requires Go 1.19 while our go.mod says Go version is 1.17.

I don't think this field means what you think it does. Or it didn't, anyway, before Go 1.21:

https://go.dev/doc/modules/gomod-ref#go

IIUC it used to only indicate the version of Go whose rules should be applied when parsing that go.mod file.

Now it seems like it means what everyone (including me) always assumed. In the meantime, we'll need to manually go get an older version of glog. :(

@dfawley dfawley assigned easwars and unassigned dfawley Jul 18, 2023
@easwars easwars merged commit d524b40 into grpc:master Jul 18, 2023
1 check passed
@easwars easwars deleted the update_go_mods_for_1.57 branch July 18, 2023 21:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Meta Github repo, process, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants