Skip to content

xds/kokoro: install go 1.17, and retry go build #5015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 30, 2021
Merged

xds/kokoro: install go 1.17, and retry go build #5015

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
aef3beb
[xds_sh] xds/kokoro: install go 1.16, and retry go build for at most …
menghanl Nov 30, 2021
7feb843
[xds_sh] update to 1.17.3
menghanl Nov 30, 2021
5ef3eef
[xds_sh] c1
menghanl Nov 30, 2021
bb3f70b
[xds_sh] try curl
menghanl Nov 30, 2021
5aa6c0e
[xds_sh] retry curl
menghanl Nov 30, 2021
f1ede36
[xds_sh] l
menghanl Nov 30, 2021
32aa96e
[xds_sh] ln
menghanl Nov 30, 2021
228443d
[xds_sh] drop v for tar
menghanl Nov 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion test/kokoro/xds.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,13 @@ shopt -s extglob
branch="${branch//[[:space:]]}"
branch="${branch##remotes/origin/}"
shopt -u extglob
go build
# Install go >= 1.14 for the new features, e.g. errors.Is()
Copy link
Member

@dfawley dfawley Nov 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment will be outdated eventually.

How about "Install a version of Go supported by gRPC"?

Copy link
Contributor Author

@menghanl menghanl Nov 30, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

Or you didn't want that e.g.?

sudo apt-get install -y wget
wget https://go.dev/dl/go1.17.3.linux-amd64.tar.gz
Copy link
Member

@dfawley dfawley Nov 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if curl is already in the VM, it would be preferable to use it. Otherwise this apt install is another potential point of failure.

Also, should these things be retried for the same reason as go build?

Copy link
Contributor Author

@menghanl menghanl Nov 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

sudo tar -C /usr/local -xvf go1.17.3.linux-amd64.tar.gz
sudo cp /usr/local/go/bin/go /usr/bin/go
Copy link
Member

@dfawley dfawley Nov 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sudo ln -s /usr/local/go/bin/go /usr/bin/go? Seems like it should work, but not 100% sure.

Copy link
Contributor Author

@menghanl menghanl Nov 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

# Retry go build on error, for at most 3 times
Copy link
Member

@dfawley dfawley Nov 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mention why? (Downloading dependencies, presumably?)

Copy link
Contributor Author

@menghanl menghanl Nov 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

for i in 1 2 3; do go build && break || sleep 5; done
popd

git clone -b "${branch}" --single-branch --depth=1 https://github.com/grpc/grpc.git
Expand Down