We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DecompressedSize
With the switch to the new encoding API and the mem package, we have a TODO and some commented out code here: https://github.com/grpc/grpc-go/blob/master/rpc_util.go#L880-L900
mem
It looks like there are no current usages of DecompressedSize defined here:
grpc-go/encoding/encoding.go
Line 42 in ada6787
There is a definition of this method here:
grpc-go/encoding/gzip/gzip.go
Line 117 in ada6787
It looks to me that we could get rid of the commented out code in rpc_util.go and get rid of the docstring that says gRPC will use this if present.
@dfawley @PapaCharlie
The text was updated successfully, but these errors were encountered:
No branches or pull requests
With the switch to the new encoding API and the
mem
package, we have a TODO and some commented out code here: https://github.com/grpc/grpc-go/blob/master/rpc_util.go#L880-L900It looks like there are no current usages of
DecompressedSize
defined here:grpc-go/encoding/encoding.go
Line 42 in ada6787
There is a definition of this method here:
grpc-go/encoding/gzip/gzip.go
Line 117 in ada6787
It looks to me that we could get rid of the commented out code in rpc_util.go and get rid of the docstring that says gRPC will use this if present.
@dfawley @PapaCharlie
The text was updated successfully, but these errors were encountered: