Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible regression when using NewClient instead of Dial #7075

Closed
arvindbr8 opened this issue Apr 2, 2024 · 1 comment
Closed

Possible regression when using NewClient instead of Dial #7075

arvindbr8 opened this issue Apr 2, 2024 · 1 comment
Assignees

Comments

@arvindbr8
Copy link
Member

#7029 introduced the NewClient() API which should potentially replace grpc.Dial()

However in this branch, when I updated the orca example to use NewClient I'm seeing an error on the client side.

2024/04/02 13:24:29 Error from UnaryEcho call: rpc error: code = DeadlineExceeded desc = context deadline exceeded

This needs investigation, and possibly prioritization before the next release this week

@arvindbr8
Copy link
Member Author

this is an issue with the way the orcaLB is setup. The UpdateClientConnState method was asserting that the resolver returns only 1 address. this was true in the case of passthrough, however since NewClient uses dns as default schema the resolver returned two addresses in Github VM (and in my local machine) - 1 ipv4 and 1 ipv6 address. This is not a regression.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant