Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a ClientConn level test for idleness race #6560

Closed
easwars opened this issue Aug 17, 2023 · 3 comments · Fixed by #6659
Closed

Add a ClientConn level test for idleness race #6560

easwars opened this issue Aug 17, 2023 · 3 comments · Fixed by #6659
Assignees
@easwars
Labels
P2 Type: Bug

Comments

@easwars
Copy link
Contributor

easwars commented Aug 17, 2023

See #6538 which was never caught by our existing tests.

One option for this test is to run cc.exitIdleMode and cc.enterIdleMode concurrently and ensure that things work as expected.
@Aditya-Sood
Copy link
Contributor

hi @easwars, can I pick this up?

@dfawley
Copy link
Member

dfawley commented Aug 21, 2023

This should wait until #6566 is merged.

@dfawley
Copy link
Member

dfawley commented Aug 22, 2023

Let's also clean up enterIdleMode: defer the unlock and also do the channelz event synchronously instead of in the goroutine at the end.

@easwars easwars mentioned this issue Sep 22, 2023
Merged
@dfawley dfawley added the P2 label Sep 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@easwars easwars

Labels
P2 Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

internal/idle: add a test that invokes ClientConn methods concurrently easwars/grpc-go
3 participants
@easwars @Aditya-Sood @dfawley