Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xds: switch endpoints watch to the new xDS client API #6265

Closed
easwars opened this issue May 9, 2023 · 1 comment
Closed

xds: switch endpoints watch to the new xDS client API #6265

easwars opened this issue May 9, 2023 · 1 comment
Assignees
@easwars
Labels
P2 Type: Internal Cleanup Refactors, etc

Comments

@easwars
Copy link
Contributor

easwars commented May 9, 2023 •
edited
Loading

cluster_resolver LB policy makes the EDS request using the old API:

grpc-go/xds/internal/xdsclient/client.go

Line 36 in 5e58734

WatchEndpoints(string, func(xdsresource.EndpointsUpdate, error)) func()

We need to switch this over to the new API:

grpc-go/xds/internal/xdsclient/client.go

Line 55 in 5e58734

WatchResource(rType xdsresource.Type, resourceName string, watcher xdsresource.ResourceWatcher) (cancel func())

@easwars easwars self-assigned this May 9, 2023
@easwars easwars mentioned this issue May 9, 2023
Closed
@zasweq zasweq assigned zasweq and unassigned easwars Jun 20, 2023
@easwars easwars assigned easwars and unassigned zasweq Jun 20, 2023
@easwars
Copy link
Contributor Author

easwars commented Jul 5, 2023

This is done.

@easwars easwars closed this as completed Jul 5, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@easwars easwars

Labels
P2 Type: Internal Cleanup Refactors, etc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@easwars @arvindbr8 @zasweq