Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc-go is now depends on gogo/protobuf instead of golang/protobuf? #2769

Closed
S-YOU opened this issue Apr 12, 2019 · 3 comments
Closed

grpc-go is now depends on gogo/protobuf instead of golang/protobuf? #2769

S-YOU opened this issue Apr 12, 2019 · 3 comments

Comments

@S-YOU
Copy link

S-YOU commented Apr 12, 2019

grpc-go is now depends on gogo/protobuf instead of golang/protobuf.
Is that intentional changes?

@menghanl
Copy link
Contributor

The gogo/protobuf dependency is introduced by the xds balancer, which now depends on the generated code from envoyproxy/go-control-plane.

#2750 will remove this dependency and also solve other xds proto related problems.

Is it causing any problems for you?

@shuya-t
Copy link

shuya-t commented Apr 13, 2019

gogo/protobuf is not an official library as far as I understand, so I am a little worried about the compatibility for future versions.

@menghanl
Copy link
Contributor

AFAIK, gogo/protobuf is quite stable.
Also, I think as long as you don't directly depend on gogo/protobuf, gRPC depending on gogo/protobuf shouldn't affect you, as non of those details is exported in gRPC's APIs.

With that all being said, the dependency has been removed in #2750, and is backported to 1.12.1. Closing this issue now. Please reply if you have further questions.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants