Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unflake GracefulStop #2703

Closed
jeanbza opened this issue Mar 20, 2019 · 0 comments · Fixed by #2857
Closed

unflake GracefulStop #2703

jeanbza opened this issue Mar 20, 2019 · 0 comments · Fixed by #2857
Assignees
@menghanl @easwars
Labels
fixit P2 Type: Testing

Comments

@jeanbza
Copy link
Member

jeanbza commented Mar 20, 2019 

[...]
E0318 19:34:25.685218    6841 clientconn.go:1186] Subchannel health check is unimplemented at server side, thus health check is disabled
E0318 19:34:37.816342    6841 http2_server.go:818] transport: failed to marshal rpc status: code:13 message:"\377\376\375" details:<type_url:"type.googleapis.com/grpc.testing.Empty" > , error: proto: field "google.rpc.Status.Message" contains invalid UTF-8
E0318 19:36:01.792418    6841 clientconn.go:1186] Subchannel health check is unimplemented at server side, thus health check is disabled
E0318 19:36:10.233347    6841 http2_server.go:818] transport: failed to marshal rpc status: code:13 message:"\377\376\375" details:<type_url:"type.googleapis.com/grpc.testing.Empty" > , error: proto: field "google.rpc.Status.Message" contains invalid UTF-8
--- FAIL: Test (91.39s)
    --- FAIL: Test/GracefulStop (0.00s)
    	gracefulstop_test.go:223: stream.Recv() = _, rpc error: code = Unavailable desc = transport is closing, want _, io.EOF
FAIL
@easwars easwars self-assigned this May 22, 2019
@menghanl menghanl added the fixit label May 23, 2019
@dfawley dfawley added P2 and removed P1 labels May 23, 2019
@menghanl menghanl self-assigned this Jun 5, 2019
@menghanl menghanl mentioned this issue Jun 8, 2019
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Dec 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@menghanl menghanl

@easwars easwars

Labels
fixit P2 Type: Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

server: fix race causing streams to be terminated by GracefulStop menghanl/grpc-go
4 participants
@menghanl @easwars @jeanbza @dfawley