Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helloworld example old context "golang.org/x/net/context" #1949

Closed
gertcuykens opened this issue Mar 28, 2018 · 2 comments
Closed

helloworld example old context "golang.org/x/net/context" #1949

gertcuykens opened this issue Mar 28, 2018 · 2 comments

Comments

@gertcuykens
Copy link

( master / Go 1.10 / OSX )

https://github.com/grpc/grpc-go/blob/master/examples/helloworld/greeter_client/main.go#L26

Please update example code to new context import, thx

@menghanl
Copy link
Contributor

Since go 1.9, x/net/context is a type alias to context, so you should not notice any difference when using.

There has been discussion on switching to the new context package, see #711.
The short conclusion is, there's currently no plan to make this change, because this is a non-issue with type alias. And the change will cause breakage for people using go versions without type alias.

@gertcuykens
Copy link
Author

ok thx closing

@lock lock bot locked as resolved and limited conversation to collaborators Sep 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants