Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsupported codec on server should fail with Unimplemented instead of attempting to use proto codec #1824

Open
dfawley opened this issue Jan 23, 2018 · 3 comments
Labels
Area: RPC Features Includes Compression, Encoding, Attributes/Metadata, Interceptors. fixit P3 Type: Bug

Comments

@dfawley
Copy link
Member

dfawley commented Jan 23, 2018

grpc-go/server.go

Lines 1433 to 1435 in f1437f7

if codec == nil {
return encoding.GetCodec(proto.Name)
}

This would be a behavior change, even though it's also a bug fix, so it would need to be carefully considered first.

@dfawley dfawley self-assigned this Jan 23, 2018
@stale stale bot added the stale label Sep 6, 2019
@dfawley dfawley removed the stale label Sep 6, 2019
@grpc grpc deleted a comment from stale bot May 3, 2021
@dfawley dfawley added P3 and removed P2 labels May 3, 2021
@dfawley dfawley removed their assignment May 3, 2021
@easwars
Copy link
Contributor

easwars commented Sep 21, 2023

@dfawley : What if we make this change, but have an env var that people can set to get the old behavior? Or, we can consider the other approach, where we throw a log saying "oh, we didnt find the codec, we are going to be using proto for now, but this change".

@dfawley
Copy link
Member Author

dfawley commented Sep 21, 2023

Yes, I think we could start by logging a warning and then have an environment variable to revert to the old behavior for a few releases.

@easwars
Copy link
Contributor

easwars commented Oct 13, 2023

Added a warning here: #6658

@eshitachandwani eshitachandwani added the Area: RPC Features Includes Compression, Encoding, Attributes/Metadata, Interceptors. label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: RPC Features Includes Compression, Encoding, Attributes/Metadata, Interceptors. fixit P3 Type: Bug
Projects
None yet
Development

No branches or pull requests

4 participants