From f135e982e6ca1949979c4e944942ccf0b20acc96 Mon Sep 17 00:00:00 2001
From: Zach Reyes <39203661+zasweq@users.noreply.github.com>
Date: Thu, 8 Feb 2024 19:03:30 -0500
Subject: [PATCH]  xds/internal/xdsclient: Add comments for exported types
 (#6972)

---
 internal/internal.go                               | 5 +++--
 xds/internal/xdsclient/xdsresource/filter_chain.go | 3 +++
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/internal/internal.go b/internal/internal.go
index 6c7ea6a5336f..5082fdaba961 100644
--- a/internal/internal.go
+++ b/internal/internal.go
@@ -190,8 +190,9 @@ var (
 	// function makes events more predictable than relying on timer events.
 	TriggerXDSResourceNameNotFoundForTesting any // func(func(xdsresource.Type, string), string, string) error
 
-	// TriggerXDSResourceNotFoundClient invokes the testing xDS Client singleton
-	// to invoke resource not found for a resource type name and resource name.
+	// TriggerXDSResourceNameNotFoundClient invokes the testing xDS Client
+	// singleton to invoke resource not found for a resource type name and
+	// resource name.
 	TriggerXDSResourceNameNotFoundClient any // func(string, string) error
 
 	// FromOutgoingContextRaw returns the un-merged, intermediary contents of metadata.rawMD.
diff --git a/xds/internal/xdsclient/xdsresource/filter_chain.go b/xds/internal/xdsclient/xdsresource/filter_chain.go
index 29b14e636bf2..23c2b79413d5 100644
--- a/xds/internal/xdsclient/xdsresource/filter_chain.go
+++ b/xds/internal/xdsclient/xdsresource/filter_chain.go
@@ -96,6 +96,8 @@ type RouteWithInterceptors struct {
 	Interceptors []resolver.ServerInterceptor
 }
 
+// UsableRouteConfiguration contains a matchable route configuration, with
+// instantiated HTTP Filters per route.
 type UsableRouteConfiguration struct {
 	VHS []VirtualHostWithInterceptors
 	Err error
@@ -504,6 +506,7 @@ func (fcm *FilterChainManager) addFilterChainsForSourcePorts(srcEntry *sourcePre
 	return nil
 }
 
+// FilterChains returns the filter chains for this filter chain manager.
 func (fcm *FilterChainManager) FilterChains() []*FilterChain {
 	return fcm.fcs
 }