Skip to content

Commit

Permalink
xds/internal/xdsclient: Add comments for exported types (#6972)
Browse files Browse the repository at this point in the history
  • Loading branch information
zasweq authored Feb 9, 2024
1 parent f8eef63 commit f135e98
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
5 changes: 3 additions & 2 deletions internal/internal.go
Original file line number Diff line number Diff line change
Expand Up @@ -190,8 +190,9 @@ var (
// function makes events more predictable than relying on timer events.
TriggerXDSResourceNameNotFoundForTesting any // func(func(xdsresource.Type, string), string, string) error

// TriggerXDSResourceNotFoundClient invokes the testing xDS Client singleton
// to invoke resource not found for a resource type name and resource name.
// TriggerXDSResourceNameNotFoundClient invokes the testing xDS Client
// singleton to invoke resource not found for a resource type name and
// resource name.
TriggerXDSResourceNameNotFoundClient any // func(string, string) error

// FromOutgoingContextRaw returns the un-merged, intermediary contents of metadata.rawMD.
Expand Down
3 changes: 3 additions & 0 deletions xds/internal/xdsclient/xdsresource/filter_chain.go
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,8 @@ type RouteWithInterceptors struct {
Interceptors []resolver.ServerInterceptor
}

// UsableRouteConfiguration contains a matchable route configuration, with
// instantiated HTTP Filters per route.
type UsableRouteConfiguration struct {
VHS []VirtualHostWithInterceptors
Err error
Expand Down Expand Up @@ -504,6 +506,7 @@ func (fcm *FilterChainManager) addFilterChainsForSourcePorts(srcEntry *sourcePre
return nil
}

// FilterChains returns the filter chains for this filter chain manager.
func (fcm *FilterChainManager) FilterChains() []*FilterChain {
return fcm.fcs
}
Expand Down

0 comments on commit f135e98

Please sign in to comment.