fix reviews

lyuxuan · lyuxuan · commit d551c4c4f2c8 · 2019-02-27T14:30:41.000-08:00
diff --git a/internal/transport/http_util.go b/internal/transport/http_util.go
@@ -275,12 +275,6 @@ func (d *decodeState) decodeHeader(frame *http2.MetaHeadersFrame) error {
 	}
 
 	for _, hf := range frame.Fields {
-		if hf.Name != "content-type" && hf.Name != ":status" && d.data.grpcErr != nil {
-			// if we've already encountered grpc related field parsing error, then we skip processing
-			// all following grpc related field.
-			continue
-		}
-
 		d.processHeaderField(hf)
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -275,12 +275,6 @@ func (d decodeState) decodeHeader(frame http2.MetaHeadersFrame) error {`
`275`	`275`	`}`
`276`	`276`
`277`	`277`	`for _, hf := range frame.Fields {`
`278`		`- if hf.Name != "content-type" && hf.Name != ":status" && d.data.grpcErr != nil {`
`279`		`- // if we've already encountered grpc related field parsing error, then we skip processing`
`280`		`- // all following grpc related field.`
`281`		`- continue`
`282`		`- }`
`283`		`-`
`284`	`278`	`d.processHeaderField(hf)`
`285`	`279`	`}`
`286`	`280`