add punctuation and default OS config to benchmark

grpc · Nov 7, 2023 · 50615a5 · 50615a5
1 parent 06962e3
commit 50615a5
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/benchmark/benchmain/main.go b/benchmark/benchmain/main.go
@@ -373,7 +373,7 @@ func makeClients(bf stats.Features) ([]testgrpc.BenchmarkServiceClient, func())
 			logger.Fatalf("Failed to listen: %v", err)
 		}
 		opts = append(opts, grpc.WithContextDialer(func(ctx context.Context, address string) (net.Conn, error) {
-			return nw.ContextDialer((&net.Dialer{}).DialContext)(ctx, "tcp", lis.Addr().String())
+			return nw.ContextDialer((&net.Dialer{KeepAlive: time.Duration(-1)}).DialContext)(ctx, "tcp", lis.Addr().String())
 		}))
 	}
 	lis = nw.Listener(lis)

diff --git a/dialoptions.go b/dialoptions.go
@@ -419,7 +419,7 @@ func WithTimeout(d time.Duration) DialOption {
 // To retain OS defaults, use a net.Dialer with the KeepAlive field set to a
 // negative value.
 //
-// For more information, please see [issue 23459] in the Go github repo
+// For more information, please see [issue 23459] in the Go github repo.
 //
 // [issue 23459]: https://github.com/golang/go/issues/23459
 func WithContextDialer(f func(context.Context, string) (net.Conn, error)) DialOption {

diff --git a/server.go b/server.go
@@ -819,7 +819,7 @@ func (l *listenSocket) Close() error {
 // To retain OS defaults, pass a net.Listener created by calling the Listen method
 // on a net.ListenConfig with the `KeepAlive` field set to a negative value.
 //
-// For more information, please see [issue 23459] in the Go github repo
+// For more information, please see [issue 23459] in the Go github repo.
 //
 // [issue 23459]: https://github.com/golang/go/issues/23459
 func (s *Server) Serve(lis net.Listener) error {