Skip to content

Commit 1aff12e

Browse files
committed
remove prefaceTimer
1 parent a195f7c commit 1aff12e

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

Diff for: clientconn.go

+1-5
Original file line numberDiff line numberDiff line change
@@ -1121,8 +1121,6 @@ func (ac *addrConn) createTransport(addr resolver.Address, copts transport.Conne
11211121
Authority: ac.cc.authority,
11221122
}
11231123

1124-
prefaceTimer := time.NewTimer(time.Until(connectDeadline))
1125-
11261124
onGoAway := func(r transport.GoAwayReason) {
11271125
ac.mu.Lock()
11281126
ac.adjustParams(r)
@@ -1132,13 +1130,11 @@ func (ac *addrConn) createTransport(addr resolver.Address, copts transport.Conne
11321130

11331131
onClose := func() {
11341132
close(onCloseCalled)
1135-
prefaceTimer.Stop()
11361133
reconnect.Fire()
11371134
}
11381135

11391136
onPrefaceReceipt := func() {
11401137
close(prefaceReceived)
1141-
prefaceTimer.Stop()
11421138
}
11431139

11441140
connectCtx, cancel := context.WithDeadline(ac.ctx, connectDeadline)
@@ -1164,7 +1160,7 @@ func (ac *addrConn) createTransport(addr resolver.Address, copts transport.Conne
11641160

11651161
if ac.dopts.reqHandshake == envconfig.RequireHandshakeOn {
11661162
select {
1167-
case <-prefaceTimer.C:
1163+
case <-time.After(connectDeadline.Sub(time.Now())):
11681164
// We didn't get the preface in time.
11691165
newTr.Close()
11701166
grpclog.Warningf("grpc: addrConn.createTransport failed to connect to %v: didn't receive server preface in time. Reconnecting...", addr)

0 commit comments

Comments
 (0)