Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using dep to depend on specific revision of golang/protobuf is causing transative dependency problems for users #829

Closed
javasgl opened this issue Dec 12, 2018 · 6 comments

Comments

@javasgl
Copy link

javasgl commented Dec 12, 2018

revision = "aa810b61a9c79d51363740d207bb46cf8e620ed5"

master: Could not introduce github.com/grpc-ecosystem/grpc-gateway@master, as it has a dependency on github.com/golang/protobuf with constraint aa810b61a9c79d51363740d207bb46cf8e620ed5, which has no overlap with existing constraint master from github.com/grpc-ecosystem/go-grpc-middleware@master

@javasgl
Copy link
Author

javasgl commented Dec 12, 2018

aa810b61a9c79d51363740d207bb46cf8e620ed5 has been merged into master.

so there should be change to branch = "master" instead of special revision.

see: golang/protobuf#679

@johanbrandhorst @yugui

@johanbrandhorst
Copy link
Collaborator

Hi @javasgl, the reason that we're using specific revisions, which I know messes with dep a little bit, is because we rely on using both dep and bazel files and we want to make sure they both match, and unfortunately the bazel dependencies all use specific revisions. In the future we're planning on ditching both in favor of go modules files, but we haven't gotten around to that work yet (help wanted!).

In the meantime, the following override should fix your problem:

[[override]]
    name = "github.com/golang/protobuf"
    version = "1.1.0" # Or whatever version you want

.

Sorry for any inconvenience this is causing to our users.

@johanbrandhorst johanbrandhorst changed the title bad revision with protobuf Using dep to depend on specific revision of golang/protobuf is causing transative dependency problems for users Dec 12, 2018
@johanbrandhorst
Copy link
Collaborator

Related to #755

@javasgl
Copy link
Author

javasgl commented Dec 12, 2018

the simplest solution at present is keep this specific revision sync with github.com/golang/protobuf master‘s revision. may be , i guess

@johanbrandhorst
Copy link
Collaborator

That would risk the dep file getting out of sync with the bazel dependencies, which is unacceptable. The best solution is to migrate this project to use go modules.

@johanbrandhorst
Copy link
Collaborator

Closing as dupe of #755

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants