Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chunked transfer encoding for streaming responses #562

Closed
theRealWardo opened this issue Feb 27, 2018 · 5 comments
Closed

chunked transfer encoding for streaming responses #562

theRealWardo opened this issue Feb 27, 2018 · 5 comments

Comments

@theRealWardo
Copy link
Contributor

I have a use case that requires streaming responses. others on the interwebs have done chunked transfer of JSON in order to improve client performance as well. for example, https://github.com/eBay/jsonpipe

has anyone tried to tackle this? are there any problems with adding this support and would this project be accepting of a PR that adds support or is the preferred approach a wrapper similar to what @tmc did with websockets in https://github.com/tmc/grpc-websocket-proxy?

@achew22
Copy link
Collaborator

achew22 commented Feb 28, 2018

I think the best way to go about it would be to imitate what @tmc did. It is a nice, clean, solution to the problem at hand and doesn't increase the API surface area for grpc-gateway. I would love to add your project to the official docs so please tell me where your projet ends up so I can add reference to it.

PS: Would you still be interested in getting #458 merged?

@theRealWardo
Copy link
Contributor Author

sounds good. I'm a fan of that approach as well. shall we leave this ticket open until I can share a repo for that or do you wanna close this out and say nope then?

yep totally interested in getting #458 merged. I'll give it a quick poke right now so someone can on the review there.

@theRealWardo
Copy link
Contributor Author

with a few patches on top of #458 - this actually works without writing any kind of a wrapper. I was pleasantly surprised. of course I'll merge those into that PR.

in our proto's service definition, we just have rpc DoTheThing(Request) returns (stream google.api.HttpBody) and it works great!

@johanbrandhorst
Copy link
Collaborator

Seems like this will be fixed by #458

@stale
Copy link

stale bot commented Sep 9, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Sep 9, 2019
@stale stale bot closed this as completed Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants