New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

returned errors should conform to google.rpc.Status #399

Closed

tmc opened this issue May 26, 2017 · 4 comments

Collaborator

tmc commented May 26, 2017

refs https://cloud.google.com/apis/design/errors

Collaborator

tamalsaha commented May 27, 2017

If you use the grpc-go/status package, you are automatically following this proto. https://github.com/grpc/grpc-go/blob/master/status/status.go#L49

Is any further change needed?

Contributor

kazegusuri commented May 27, 2017

Yes, status proto as error was introduced via #378.

Collaborator Author

tmc commented May 28, 2017

I'm referring to the fields that are encoded on the errorBody type

Collaborator Author

tmc commented May 30, 2017

This is addressed by #378, my mistake.

tmc closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment