Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output file will not compile if the .proto file does not contain a service with parameters in the url path #389

Closed
wrrn opened this issue May 13, 2017 · 2 comments

Comments

@wrrn
Copy link

wrrn commented May 13, 2017

If there is a .proto file that look like this:

syntax = "proto3";

import "google/api/annotations.proto";
import "google/protobuf/empty.proto";

package status;

service HealthCheck {
  rpc GetStatus(google.protobuf.Empty) returns (Status){
    option (google.api.http) = {
      get: "/status" // notice that it does not have any parameters in the path
    };
  }
}

message Request{}

message Status {
  uint32 status = 1;
}

The resulting status.gw.pb.go file will not compile. go build results in ./status.pb.gw.go:24: imported and not used: "google.golang.org/grpc/status"

@wrrn wrrn changed the title Output file will not compile if the proto file does not contain a service with url parameters Output file will not compile if the .proto file does not contain a service with url parameters May 13, 2017
@wrrn wrrn changed the title Output file will not compile if the .proto file does not contain a service with url parameters Output file will not compile if the .proto file does not contain a service with parameters in the url path May 13, 2017
@tmc
Copy link
Collaborator

tmc commented May 13, 2017

@wrrn thank you for your issue report. @tamalsaha hopped on this at #387

@wrrn
Copy link
Author

wrrn commented May 13, 2017

Awesome Thanks

@achew22 achew22 closed this as completed Dec 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants