Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question: Why passing context to RegisterMyServiceHandler is required? #301

Closed
c4milo opened this issue Jan 17, 2017 · 2 comments
Closed

Question: Why passing context to RegisterMyServiceHandler is required? #301

c4milo opened this issue Jan 17, 2017 · 2 comments

Comments

@c4milo
Copy link

c4milo commented Jan 17, 2017

Why not getting it from http.Request inside each mux.Handle? I'm curious
@c4milo c4milo changed the title Question: Why passing context to RegisterAppHandler is required? Question: Why passing context to RegisterMyServiceHandler is required? Jan 17, 2017
@ilius
Copy link

ilius commented Mar 8, 2017 •
edited
Loading

Go's "net/http" package is HTTP/1, and the context it has is as in "context" package
GRPC is HTTP/2 and it's context is "golang.org/x/net/context"
Package "context" is not even imported the .go files generated by protoc

@tmc
Copy link
Collaborator

tmc commented Mar 8, 2017

@c4milo this capability is exposed behind a flag at the moment and we have #313 open as well

@tmc tmc closed this as completed Apr 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tmc @c4milo @ilius