Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to Allow Swagger for DELETEs with a body #279

Closed
msample opened this issue Dec 11, 2016 · 1 comment
Closed

Option to Allow Swagger for DELETEs with a body #279

msample opened this issue Dec 11, 2016 · 1 comment

Comments

@msample
Copy link
Contributor

msample commented Dec 11, 2016 •
edited
Loading

Retro-specifying some legacy REST services in GRPC+REST annotations causes swagger generation from the GRPC to fail when rpc methods use http delete and have a request body.

Using a body with delete is certainly bad style so this check should not be implicitly disabled. I have a PR #280 that adds a bool "allow_delete_body" plugin parameter that defaults to false.
@msample msample mentioned this issue Dec 12, 2016
Merged
@tmc
Copy link
Collaborator

tmc commented Jan 10, 2017

The related issue is merged now.

@tmc tmc closed this as completed Jan 10, 2017
@tamalsaha tamalsaha mentioned this issue Mar 30, 2017
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tmc @msample