Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support protobuf-over-HTTP #124

Closed
tamird opened this issue Mar 4, 2016 · 3 comments
Closed

support protobuf-over-HTTP #124

tamird opened this issue Mar 4, 2016 · 3 comments
Labels
enhancement

Comments

@tamird
Copy link
Contributor

tamird commented Mar 4, 2016

It'd be cool to provide encoded protobuf support in addition to JSON from the endpoints generated by grpc-gateway. This can be done by switching on the incoming request's content type as is done in MarshalResponse and UnmarshalRequest in https://github.com/cockroachdb/cockroach/blob/master/util/http.go
@tamird tamird mentioned this issue Mar 4, 2016
Closed
@philips
Copy link

philips commented Mar 4, 2016

@tamird that is a cool use case. But, I think you missed a line number anchor in your example.

@tamird
Copy link
Contributor Author

tamird commented Mar 4, 2016

Didn't intend to line anchor - look for the functions I mentioned by name.

@tamird tamird mentioned this issue May 9, 2016
Merged
@tamird
Copy link
Contributor Author

tamird commented Jun 11, 2016

This is sufficiently supported now. See cockroachdb/cockroach#6754 for an example.

@tamird tamird closed this as completed Jun 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yugui @philips @tamird