Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: support of go protocol buffer v2 #1147

Closed
strobil opened this issue Mar 3, 2020 · 4 comments
Closed

Feature request: support of go protocol buffer v2 #1147

strobil opened this issue Mar 3, 2020 · 4 comments
Labels
breaking change Will require a major version increment enhancement
Milestone

Comments

@strobil
Copy link
Contributor

strobil commented Mar 3, 2020

Hello!
Do you plan to migrate to this new protobuf-go module?

Thank you.

@johanbrandhorst
Copy link
Collaborator

We haven't looked at the consequences yet, but I think we may want to stay on golang/[email protected] when it comes out, rather than making a slightly breaking change and move to the new import. We'll see what our users need.

@stale
Copy link

stale bot commented May 2, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label May 2, 2020
@johanbrandhorst
Copy link
Collaborator

Thanks Stale bot, as it turns out, we're going to be doing this in the v2 release of the gateway. The v2 branch is already using the new protobuf API.

@stale stale bot removed the wontfix label May 2, 2020
@johanbrandhorst johanbrandhorst added this to the 2.0 milestone May 2, 2020
@johanbrandhorst johanbrandhorst added enhancement breaking change Will require a major version increment labels May 2, 2020
@johanbrandhorst johanbrandhorst mentioned this issue May 2, 2020
13 tasks
@johanbrandhorst
Copy link
Collaborator

This is merged into v2, so closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Will require a major version increment enhancement
Projects
None yet
Development

No branches or pull requests

2 participants