Add ruby 2.4 support in travis #205
Conversation
jrafanie
force-pushed
the
add_ruby24_to_travis
branch
from
49d7f57
to
d069856
Compare
jrafanie
changed the title
|
thx, try a |
jrafanie
force-pushed
the
add_ruby24_to_travis
branch
from
d069856
to
64eae43
Compare
jrafanie
changed the title
|
I was wrong. I can't get this to pass on 2.4.1 locally. |
|
maybe simplest to do |
- diff-lcs fix upgrade fixes ruby 2.4 deprecations - Upgrade rspec and rspec-rerun Prior to this version, ruby 2.4.1 would get the following error on 4 tests: `SQLite3::SQLException: cannot rollback - no transaction is active: rollback transaction (ActiveRecord::StatementInvalid)`
jrafanie
force-pushed
the
add_ruby24_to_travis
branch
from
64c8e59
to
53c075d
Compare
|
Yes, @grosser, I did that. Although, this seems like an actual issue with 2.4. I'm still tracking it down. Do you have any suggestions? |
|
Nah ... might be sqlite being incompatible ... see if there is anything obvious wrong with the testcase setup / if it works when run with just ruby ... otherwise skip them on 2.4 ... it's not parallels job to fix sqlite ... |
As an aside, since Rails 5.1 is now out, technically Rails 4.2 has gone into security only mode with Rails 5.0 and 5.1 being the supported versions. |
|
@Fryguy We can't upgrade the test environment rails to 5 since it requires ruby 2.2 or higher I think and parallel is tested all the way back to ruby 1.9.3 |
|
can exclude the unsupported combinations like rails 5.0 + 1.9 from the build matrix |
We need this sqlite tempfile to stick around until we're done doing queries so reference the Tempfile and explicitly close and unlink it when we're done. This seems to resolve a test issue on ruby 2.4.1 where queries were failing in threads or processes with: `attempt to write a readonly database`
|
Ok, @grosser I think I got the sqlite issue under control. See the last commit. |
|
good find! |
|
FYI switched to Templfile.open in d396783 |
|
Looks good @grosser |
Note, we need to update to rails 4.2.8 or higher for ruby 2.4 support
See: rails/rails#27473