From 5bfc6538ce46ea125668a80df079c7a7b9818fc7 Mon Sep 17 00:00:00 2001 From: Eric Milles Date: Wed, 12 Apr 2017 11:59:40 -0500 Subject: [PATCH] Fix for issue #277: three error log entries when Buildship not installed --- .../eclipse/ui/decorators/GroovyPluginImages.java | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/ide/org.codehaus.groovy.eclipse.ui/src/org/codehaus/groovy/eclipse/ui/decorators/GroovyPluginImages.java b/ide/org.codehaus.groovy.eclipse.ui/src/org/codehaus/groovy/eclipse/ui/decorators/GroovyPluginImages.java index 87bac2c038..ff4c633b49 100644 --- a/ide/org.codehaus.groovy.eclipse.ui/src/org/codehaus/groovy/eclipse/ui/decorators/GroovyPluginImages.java +++ b/ide/org.codehaus.groovy.eclipse.ui/src/org/codehaus/groovy/eclipse/ui/decorators/GroovyPluginImages.java @@ -31,15 +31,12 @@ private static ImageDescriptor createDescriptor(String path) { } private static ImageDescriptor createDescriptor2(String path) { - ImageDescriptor desc; try { - desc = ImageDescriptor.createFromURL(new java.net.URL(path)); - org.eclipse.swt.graphics.Image img = desc.createImage(false); - if (img != null) { img.dispose(); } else { desc = null; } + java.net.URL url = new java.net.URL(path); + url.openConnection(); // does image exist? + return ImageDescriptor.createFromURL(url); } catch (Exception e) { - e.printStackTrace(); - desc = null; + return null; } - return desc; } }