Skip to content
This repository has been archived by the owner on Apr 23, 2020. It is now read-only.

Don't force sass loader to allow using grommet #1210 #5

Closed
shai32 opened this issue Feb 25, 2017 · 2 comments
Closed

Don't force sass loader to allow using grommet #1210 #5

shai32 opened this issue Feb 25, 2017 · 2 comments

Comments

@shai32
Copy link

shai32 commented Feb 25, 2017

I think that forcing importing a sass file is a wrong approach
import 'grommet/scss/vanilla/index';

as we know create-react-app is very popular but we can't use it with grommet

we can solve it easily by adding a compiled css into grommet package
so we can just import a simple vanila css.

Thats good not only for create-react-app but also for anyone that don't want to add sass loader
only for using grommet.

Thats one limitation we can just remove

@ugurcemozturk
Copy link

This article solved my problem, check this out : https://medium.com/@luce.williamt/using-grommet-with-create-react-app-8e8ddaa836ee#.17fk1ypyt
@shai32 #Please inform me if your problem solved or not.

@tracybarmore
Copy link

tracybarmore commented Feb 28, 2017

Closing with grommet/grommet#1210 closure.
Also, a fun read: facebook/create-react-app#1639

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants