Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkin assets with no assigned user #69

Closed
wants to merge 9 commits into from

Conversation

elyscape
Copy link
Contributor

Resolves: #68

leifahlgrimm and others added 9 commits May 5, 2020 23:21
Removed the isdigit() check for the Snipe asset tag as this creates issues when a non-digit prefix is used.
Fix asset tag only updating when number
Exceptions aren't very likely during this initialization step, but if
they occur the user definitely wants to know about them.
I fixed two condition checks to make sure the data from Jamf and the data from Snipe are aligned.

These are successfully set attributes, but showing as failing because the data doesn't line up at time of comparison.

Snipe adds " 00:00:00" to the date, and json reports None for a blank value while the Jamf data contains an empty string.

By doing these two conditional checks, I stop getting 3 warnings for ever machine updating that has these attributes updating in the case of purchase date, or not changing as is the case with my empty custom attributes.
Fixed two condition checks for confirming updating fields
This is helpful to run the same script in multiple environments, where
adapting the `settings.conf` file might not be possible or desirable.
This moves the sample settings.conf file to settings.conf.example to
help users and developers avoid accidentally committing and publishing
their credentials.
@ParadoxGuitarist ParadoxGuitarist changed the base branch from master to devel January 16, 2022 01:20
@ParadoxGuitarist
Copy link
Collaborator

@elyscape First off, thanks for making all these PRs. I finally got around to merging all of them. Can I bother you to redo this one? I think it generated a significant number of merge conflicts. Sorry.

@ParadoxGuitarist
Copy link
Collaborator

Actually I'm going to close this for now.

As I mentioned in the previous ticket, code looks good to me, but let's add it as a runtime flag. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check-in assets that have no user assigned in Jamf
6 participants