Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix behavior of gscloud-server-create --password #90

Closed
bkircher opened this issue Nov 29, 2020 · 0 comments
Closed

Fix behavior of gscloud-server-create --password #90

bkircher opened this issue Nov 29, 2020 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@bkircher
Copy link
Contributor

bkircher commented Nov 29, 2020

In gscloud-server-create, --password is mandatory when creating with storage. This is not enforced by gscloud but API calls fail if user forgets to give a PW. Actually this is fine but annoyingly late.

Second thing is that --password is not used at all when --with-template is not given. Also makes sense since we don't need to set a root PW if we don't create a new storage from a OS template. But again, this is annoyingly silent on this user "error".

Lastly, maybe we just should remove --password flag oand not allow the user to set passwords themselves. For one thing, thse passwords wouldn't be recorded by shell history anymore (good) and user cannot forget to specify one (good). We could use something like https://github.com/sethvargo/go-password to always generate sufficiently secure passwords and return them after the server (erm, storage) has been created.

@bkircher bkircher added the enhancement New feature or request label Nov 29, 2020
@bkircher bkircher added this to the v0.7.0 milestone Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant