Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loop should break when episode is done #4

Open
Driesssens opened this issue Oct 24, 2018 · 1 comment
Open

Loop should break when episode is done #4

Driesssens opened this issue Oct 24, 2018 · 1 comment

Comments

@Driesssens
Copy link

Hi, I believe we should break out of the

for step in range(args.rnn_steps):

loop when done == True. Currently, when the environment indicates that the episode is done, the loop continues to go on for a couple of steps. Not sure how the Gym environment responds to that, but new values, rewards etc keep being added to the lists and that can't be good for training.

@mimoralea
Copy link

I agree... I had this issue and add it myself after line 146 here:

https://github.com/greydanus/baby-a3c/blob/master/baby-a3c.py#L144-L146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants