Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix needs for uuid #24

Closed
kevin-li-unloan opened this issue Oct 18, 2023 · 8 comments
Closed

hotfix needs for uuid #24

kevin-li-unloan opened this issue Oct 18, 2023 · 8 comments

Comments

@kevin-li-unloan
Copy link

https://github.com/gregsdennis/dependencies-action/blob/main/node_modules/.bin/uuid is symlink

@gregsdennis
Copy link
Owner

I don't understand. Can you elaborate on what the actual problem is?

@leocencetti
Copy link

@gregsdennis the action setup fails with:

Current runner version: '2.310.2'
Operating System
Runner Image
Runner Image Provisioner
GITHUB_TOKEN Permissions
Secret source: Actions
Prepare workflow directory
Prepare all required actions
Getting action download info
Download action repository 'gregsdennis/[email protected]' (SHA:[2](https://github.com/fbx-org/MAVLink-mavros/actions/runs/6557743369/job/17810206240#step:1:2)8d95779f2ba3e9197184e0d917984b810943f[6](https://github.com/fbx-org/MAVLink-mavros/actions/runs/6557743369/job/17810206240#step:1:7)e)
Error: Could not find file '/home/runner/work/_actions/_temp_e073b0b6-f1c3-475f-9316-2450052bd601/_staging/gregsdennis-dependencies-action-28d9577/node_modules/.bin/uuid'.

@leocencetti
Copy link

As @kevin-li-unloan said, the uuid script under node_modules/.bin is a symlink (GitHub shows it nicely here).

@gregsdennis
Copy link
Owner

gregsdennis commented Oct 18, 2023

Hm... I wonder if I can leave the test dependencies out of the repo.

The docs say that node_modules needs to be checked in, but just adding jest added a LOT of packages. Given that it's not needed to run the action, maybe I can just remove those.

I'll work on that tomorrow. In the meantime, pin the version in your YAML file.

@leocencetti
Copy link

Did some digging in the repo sources and the symlink seems indeed broken/invalid (it points to an inline script):

image

It should be enough to replace it with a regular file containing the current target script (same as for uuid.cmd and uuid.ps1 files in the same dir).

@gregsdennis
Copy link
Owner

I did a clean removal and reinstall of all of the npm modules. Will publish again.

@gregsdennis
Copy link
Owner

gregsdennis commented Oct 18, 2023

Looks to be working now. Let me know if you continue to have problems.

cc: @kevin-li-unloan @leocencetti @Czaki @bprather

@bprather
Copy link

Looks to be working for us. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants