Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript import type for SVGProps in generated files #842

Closed
johncch opened this issue Mar 27, 2023 · 3 comments
Closed

Typescript import type for SVGProps in generated files #842

johncch opened this issue Mar 27, 2023 · 3 comments

Comments

@johncch
Copy link
Contributor

johncch commented Mar 27, 2023

Hello! Thanks for all the good work!

In Typescript 5.0, they shipped the --verbatimModuleSyntax flag that helps make type and value import declaration more explicit.

As a result, when the flag is turned on, the compiler will warn about non-type inputs. Here is an example:
image

It doesn't seem like there's an easy way to change the import syntax through the template. Is this something that can be done via configurations?

Thank you!

@gregberge
Copy link
Owner

Pull request is welcome for that.

@johncch
Copy link
Contributor Author

johncch commented Mar 28, 2023

I will take a look at this later this week and submit a pull request. Thank you.

@johncch
Copy link
Contributor Author

johncch commented May 11, 2023

Closed by #853

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants