perf: avoid calling stats.toJson if possible

hedgepigdaniel · hedgepigdaniel · commit 87698de079cb · 2019-12-20T17:03:14.000+11:00
diff --git a/packages/webpack-plugin/src/index.js b/packages/webpack-plugin/src/index.js
@@ -75,7 +75,9 @@ class LoadablePlugin {
     // Add a custom output.jsonpFunction: __LOADABLE_LOADED_CHUNKS__
     compiler.options.output.jsonpFunction = '__LOADABLE_LOADED_CHUNKS__'
 
-    compiler.hooks.emit.tapAsync('@loadable/webpack-plugin', this.handleEmit)
+    if (this.opts.outputAsset || this.opts.writeToDisk) {
+      compiler.hooks.emit.tapAsync('@loadable/webpack-plugin', this.handleEmit)
+    }
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,9 @@ class LoadablePlugin {`
`75`	`75`	`// Add a custom output.jsonpFunction: __LOADABLE_LOADED_CHUNKS__`
`76`	`76`	`compiler.options.output.jsonpFunction = '__LOADABLE_LOADED_CHUNKS__'`
`77`	`77`
`78`		`- compiler.hooks.emit.tapAsync('@loadable/webpack-plugin', this.handleEmit)`
	`78`	`+ if (this.opts.outputAsset \|\| this.opts.writeToDisk) {`
	`79`	`+ compiler.hooks.emit.tapAsync('@loadable/webpack-plugin', this.handleEmit)`
	`80`	`+ }`
`79`	`81`	`}`
`80`	`82`	`}`
`81`	`83`