Fix: Unwrap SSL socket before closing transport socket. (#737)

* Update connections.py Unwrap the SSL socket before closing the underlying transport socket instead of just closing SSL socket, to avoid yielding a "The TLS connection was non-properly terminated" warning in gvmd.log on disconnect. * cosmetics gvm/connections.py Co-authored-by: Jaspar S. <[email protected]>
greenbone · May 19, 2022 · a1fc99e · a1fc99e
1 parent 227abea
commit a1fc99e
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/gvm/connections.py b/gvm/connections.py
@@ -467,6 +467,15 @@ def connect(self):
         self._socket = self._new_socket()
         self._socket.connect((self.hostname, int(self.port)))
 
+    def disconnect(self):
+        """Close the SSL layer then disconnect from the remote server"""
+        try:
+            if self._socket is not None:
+                self._socket = self._socket.unwrap()
+        except OSError as e:
+            logger.debug("Connection closing error: %s", e)
+        return super(TLSConnection, self).disconnect()
+
 
 class UnixSocketConnection(GvmConnection):
     """