Skip to content

Commit 6345964

Browse files
daniele-mngdaniele-mng
authored
deps: update eslint to v9 add formatting rules and remove unused deps (#4255)
* deps: update eslint to v9 add formatting rules and remove unused deps * update github action linting * autofix linting * fix non autofix linting issues * remove vim setting comment * update @vitest/eslint-plugin
1 parent 8d6368c commit 6345964

File tree

1,588 files changed

+9172
-16034
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

1,588 files changed

+9172
-16034
lines changed

‎.eslintrc.cjs

-86
This file was deleted.

‎.github/workflows/ci-js.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ jobs:
8686
- name: Install dependencies
8787
run: npm install
8888
- name: Lint JavaScript files
89-
run: npm run lint -- --format junit -o ${{ env.REPORT_FILE }}
89+
run: npm run lint > ${{ env.REPORT_FILE }}
9090
- name: Store Lint Results
9191
uses: actions/upload-artifact@v4
9292
with:

‎allowedSnakeCase.cjs ‎allowedSnakeCase.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
* SPDX-License-Identifier: AGPL-3.0-or-later
44
*/
55

6-
module.exports = [
6+
const allowedSnakeCase = [
77
'access_hosts',
88
'action_result',
99
'actions_column',
@@ -693,3 +693,5 @@ module.exports = [
693693
'yes_no_props',
694694
'zh_TW',
695695
];
696+
697+
export default allowedSnakeCase;

‎eslint.config.js

+138
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,138 @@
1+
import pluginJs from '@eslint/js';
2+
import pluginHeader from 'eslint-plugin-header';
3+
import pluginReact from 'eslint-plugin-react';
4+
import pluginReactHooks from 'eslint-plugin-react-hooks';
5+
import globals from 'globals';
6+
import * as importPlugin from 'eslint-plugin-import';
7+
import vitest from '@vitest/eslint-plugin';
8+
import allowedSnakeCase from './allowedSnakeCase.js';
9+
10+
pluginHeader.rules.header.meta.schema = false; // https://github.com/Stuk/eslint-plugin-header/issues/57
11+
12+
export default [
13+
pluginJs.configs.recommended,
14+
pluginReact.configs.flat?.recommended,
15+
{
16+
ignores: ['build', 'eslint.config.js'],
17+
},
18+
{
19+
files: ['**/*.{js,mjs,cjs,jsx}'],
20+
},
21+
{
22+
plugins: {
23+
react: pluginReact,
24+
'react-hooks': pluginReactHooks,
25+
vitest,
26+
import: importPlugin,
27+
header: pluginHeader,
28+
},
29+
},
30+
{
31+
settings: {
32+
react: {
33+
version: 'detect',
34+
},
35+
},
36+
languageOptions: {
37+
parserOptions: {
38+
ecmaFeatures: {
39+
jsx: true,
40+
},
41+
},
42+
globals: {
43+
...globals.browser,
44+
...globals.node,
45+
describe: 'readonly',
46+
it: 'readonly',
47+
expect: 'readonly',
48+
beforeEach: 'readonly',
49+
afterEach: 'readonly',
50+
beforeAll: 'readonly',
51+
afterAll: 'readonly',
52+
vi: 'readonly',
53+
},
54+
},
55+
},
56+
{
57+
rules: {
58+
...pluginReactHooks.configs.recommended.rules,
59+
'react/react-in-jsx-scope': 'off',
60+
'react/prop-types': [
61+
'warn',
62+
{
63+
ignore: ['children', 'className', 'location'],
64+
},
65+
],
66+
'no-unused-vars': [
67+
'warn',
68+
{
69+
args: 'none',
70+
ignoreRestSiblings: true,
71+
},
72+
],
73+
camelcase: [
74+
'warn',
75+
{
76+
allow: allowedSnakeCase,
77+
properties: 'always',
78+
},
79+
],
80+
'react/display-name': 'off',
81+
'no-class-assign': 'off',
82+
'no-prototype-builtins': 'off',
83+
'no-case-declarations': 'off',
84+
'react-hooks/exhaustive-deps': 'warn',
85+
'header/header': [
86+
2,
87+
'block',
88+
[
89+
{
90+
pattern: ' SPDX-FileCopyrightText: \\d{4} Greenbone AG',
91+
template: ' SPDX-FileCopyrightText: 2024 Greenbone AG',
92+
},
93+
' *',
94+
' * SPDX-License-Identifier: AGPL-3.0-or-later',
95+
' ',
96+
],
97+
2,
98+
],
99+
'react/jsx-sort-props': [
100+
'error',
101+
{
102+
callbacksLast: true,
103+
shorthandFirst: true,
104+
ignoreCase: false,
105+
reservedFirst: true,
106+
noSortAlphabetically: false,
107+
},
108+
],
109+
'import/order': [
110+
'error',
111+
{
112+
groups: [
113+
['builtin', 'external'],
114+
['internal'],
115+
['parent', 'sibling', 'index'],
116+
],
117+
'newlines-between': 'always',
118+
alphabetize: {
119+
order: 'asc',
120+
caseInsensitive: true,
121+
},
122+
},
123+
],
124+
},
125+
},
126+
127+
{
128+
files: ['**/__tests__/**/*.[jt]s?(x)', '**/?(*.)+(spec|test).[jt]s?(x)'],
129+
plugins: {vitest},
130+
rules: {
131+
...vitest.configs.recommended.rules,
132+
'vitest/no-focused-tests': 'error',
133+
'vitest/no-disabled-tests': 'warn',
134+
'vitest/no-identical-title': 'error',
135+
'react/prop-types': 'off',
136+
},
137+
},
138+
];

0 commit comments

Comments
 (0)