Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Plugin to work with new Notification/Alert System in Graylog 3.1 #89

Open
jalogisch opened this issue Sep 6, 2019 · 14 comments
Open

Comments

@jalogisch
Copy link

This Plugin needs to be updated to work with the new alerting/notification system.

@jozefbarcin
Copy link

is not working with Graylog 3.1.2 as well: Legacy alarm callbacks are deprecated. Please switch to the new notification types as soon as possible!

@tabascoterrier
Copy link

I'm sorely tempted to have a go at this, it would be extremely useful for us (the existing version seems to duplicate some backlog items in 3.1).

This would be my first foray into Graylog development, is there an example 3.1 alert plugin that anyone can point me at?

@bernd
Copy link
Contributor

bernd commented Sep 26, 2019

@tabascoterrier That would be awesome! 😃

There is no external plugin yet but you can take a look at the HTTP event notification in the server repository. All the internal notifications are implemented as plugins as well:

@tabascoterrier
Copy link

Thanks @bernd, I'll have a look!

@sboeingSPA
Copy link

As i had the same problem i simply wrote a new slack plugin for graylog 3.1 using the new notification system.
As the code significantly changed i created it as a new project instead of a merge request.

https://marketplace.graylog.org/addons/d87f19f5-4a91-4099-8179-c4700b6c8f6d
https://github.com/sportalliance/graylog-plugin-slack-notification

@radykal-com
Copy link

Is anyone working on this? If not I will take care of it as I really need it

@bernd
Copy link
Contributor

bernd commented Oct 24, 2019

@radykal-com Feel free to work on this! 😃 Thank you! 👍

@sboeingSPA
Copy link

@radykal-com I would recommend you the plugin I wrote and mentioned three comments above.
Only the support of matterhorn has been dropped but slack is working the same way as in this plugin

@radykal-com
Copy link

@sboeingSPA why dont contribute your changes back to the original plugin? Its much easier to maintain one plugin instead of 2 different ones that actually are doing the same.

@sboeingSPA
Copy link

Because all the code of the original plugin is deprecated. Meaning i would deleted all of it and replace it with new one. But the original plugin currently supports Mattermost which i don't know and don't want to explicitly support and test.

Also this project looks quite unmaintained to me. The last release is more than a year old and there are merge requests no one takes care of.

@Aenima4six2
Copy link
Contributor

@sboeingSPA Please feel free to submit your work as a PR, regardless how much code you changed. I do my best to check in on this repo from time to time for critical issues, but I have a full time career not affiliated with Graylog and a family. There is only so much time I can contribute. If you would like to take over repository maintenance, I’m happy to pass the torch.

@bernd
Copy link
Contributor

bernd commented Nov 4, 2019

@sboeingSPA @Aenima4six2 Thanks folks for taking care! 👍

We don't need to delete the legacy plugin. I think it's good to keep it until everyone migrated off to the new event notification. So it would be enough to just add the new event notification code to the existing structure.

@radykal-com radykal-com removed their assignment Nov 11, 2019
@sboeingSPA
Copy link

@bernd @Aenima4six2 i will take another look into it the next weeks during my vacation

@Bacto
Copy link

Bacto commented Feb 18, 2020

Hi everyone,

Any news on this? We miss this plugin in Graylog :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants