Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature req: bors queue should also link to head commit #29

Open
pnkfelix opened this issue Mar 29, 2014 · 0 comments
Open

feature req: bors queue should also link to head commit #29

pnkfelix opened this issue Mar 29, 2014 · 0 comments

Comments

@pnkfelix
Copy link

There is a problem with the bors UX.

It is documented on discussion here: rust-lang/rust#13157 (comment)

The summary is that github presents commits in a PR in chronological order, not topological order. So it is easy for a reviewer to mistakenly put the r+ mark on a non-head commit.

To work-around this, it would be nice if the bors queue would present a link to the head commit for a PR.


(As a side-feature, it might also be good if bors somehow indicated if there is already an r+ mark on any commit other than the head one in the PR, so that people reviewing the queue could easily see if if a given PR has already been ("partially") reviewed and/or if the reviewer may have mistakenly put the r+ on the wrong commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant