You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The summary is that github presents commits in a PR in chronological order, not topological order. So it is easy for a reviewer to mistakenly put the r+ mark on a non-head commit.
To work-around this, it would be nice if the bors queue would present a link to the head commit for a PR.
(As a side-feature, it might also be good if bors somehow indicated if there is already an r+ mark on any commit other than the head one in the PR, so that people reviewing the queue could easily see if if a given PR has already been ("partially") reviewed and/or if the reviewer may have mistakenly put the r+ on the wrong commit.
The text was updated successfully, but these errors were encountered:
There is a problem with the bors UX.
It is documented on discussion here: rust-lang/rust#13157 (comment)
The summary is that github presents commits in a PR in chronological order, not topological order. So it is easy for a reviewer to mistakenly put the
r+
mark on a non-head commit.To work-around this, it would be nice if the bors queue would present a link to the head commit for a PR.
(As a side-feature, it might also be good if bors somehow indicated if there is already an
r+
mark on any commit other than the head one in the PR, so that people reviewing the queue could easily see if if a given PR has already been ("partially") reviewed and/or if the reviewer may have mistakenly put ther+
on the wrong commit.The text was updated successfully, but these errors were encountered: